test(acceptance): skip rate limit to avoid flaky tests

bastean · Feb 13, 2025 · 73224ca · 73224ca
1 parent 8b254d9
commit 73224ca
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/internal/app/server/middleware/limiter.go b/internal/app/server/middleware/limiter.go
@@ -5,6 +5,7 @@ import (
 	"time"
 
 	ratelimit "github.com/JGLTechnologies/gin-rate-limit"
+	"github.com/bastean/codexgo/v4/internal/pkg/service/env"
 	"github.com/gin-gonic/gin"
 )
 
@@ -14,6 +15,9 @@ func RateLimiter() gin.HandlerFunc {
 			&ratelimit.InMemoryOptions{
 				Rate:  time.Second,
 				Limit: 10,
+				Skip: func(c *gin.Context) bool {
+					return env.IsServerGinModeTest()
+				},
 			},
 		),
 		&ratelimit.Options{

diff --git a/internal/app/server/service/captcha/captcha.go b/internal/app/server/service/captcha/captcha.go
@@ -33,7 +33,7 @@ func Generate() (*Captcha, error) {
 }
 
 func Verify(id, answer string) error {
-	if !base64Captcha.DefaultMemStore.Verify(id, answer, false) && env.IsNotServerGinModeTest() {
+	if !base64Captcha.DefaultMemStore.Verify(id, answer, false) && !env.IsServerGinModeTest() {
 		return errors.New[errors.Failure](&errors.Bubble{
 			Where: "Verify",
 			What:  "Wrong captcha answer",

diff --git a/internal/pkg/service/env/server.go b/internal/pkg/service/env/server.go
@@ -28,6 +28,6 @@ func HasServerGinProxy() (string, bool) {
 	return "", false
 }
 
-func IsNotServerGinModeTest() bool {
-	return ServerGinMode != "test"
+func IsServerGinModeTest() bool {
+	return ServerGinMode == "test"
 }