fix(server): clear captcha only after a successful command

bastean · Feb 17, 2025 · 205acdd · 205acdd
1 parent 9902916
commit 205acdd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/internal/app/server/handler/user/create.go b/internal/app/server/handler/user/create.go
@@ -37,8 +37,6 @@ func Create(c *gin.Context) {
 		return
 	}
 
-	captcha.Clear(data.CaptchaID)
-
 	err = command.Bus.Dispatch(messages.New(
 		create.CommandKey,
 		&create.CommandAttributes{
@@ -56,6 +54,8 @@ func Create(c *gin.Context) {
 		return
 	}
 
+	captcha.Clear(data.CaptchaID)
+
 	c.JSON(http.StatusCreated, &reply.JSON{
 		Success: true,
 		Message: "Account created",

diff --git a/internal/app/server/handler/user/forgot.go b/internal/app/server/handler/user/forgot.go
@@ -37,8 +37,6 @@ func Forgot(c *gin.Context) {
 		return
 	}
 
-	captcha.Clear(data.CaptchaID)
-
 	err = command.Bus.Dispatch(messages.New(
 		forgot.CommandKey,
 		&forgot.CommandAttributes{
@@ -53,6 +51,8 @@ func Forgot(c *gin.Context) {
 		return
 	}
 
+	captcha.Clear(data.CaptchaID)
+
 	c.JSON(http.StatusOK, &reply.JSON{
 		Success: true,
 		Message: "Link sent. Please check your inbox",