fix(date): change date only when previous and selected are both not e…

…mpty, null or undefined
baloise · Sep 13, 2024 · bc69750 · bc69750
1 parent 8502f0a
commit bc69750
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/packages/core/src/components/bal-date/bal-date.tsx b/packages/core/src/components/bal-date/bal-date.tsx
@@ -440,7 +440,7 @@ export class Date implements ComponentInterface, Loggable, BalAriaFormLinking {
 
   private onInputChange = (ev: BalEvents.BalInputDateChange) => {
     stopEventBubbling(ev)
-    if (ev.detail) {
+    if (!(BalDate.isEmptyDate(ev.detail) && BalDate.isEmptyDate(this.value))) {
       this.value = ev.detail
       this.balChange.emit(this.value)
     }

diff --git a/packages/core/src/utils/date/date.spec.ts b/packages/core/src/utils/date/date.spec.ts
@@ -147,5 +147,14 @@ describe('balDate', () => {
         expect(BalDate.fromISO(date2).isBeforeOrEqual(date1)).toBeFalsy()
       })
     })
+    describe('isEmptyDate', () => {
+      test('should return if date is empty, null or undefined', () => {
+        const date = BalDate.fromISO('2001-02-01')
+        expect(BalDate.isEmptyDate(null)).toBeTruthy()
+        expect(BalDate.isEmptyDate('')).toBeTruthy()
+        expect(BalDate.isEmptyDate(undefined)).toBeTruthy()
+        expect(date).toBeFalsy()
+      })
+    })
   })
 })
diff --git a/packages/core/src/utils/date/date.ts b/packages/core/src/utils/date/date.ts
@@ -66,6 +66,10 @@ export class BalDate {
     return weekdays
   }
 
+  public static isEmptyDate(value: any): boolean {
+    return value === undefined || value === null || value === ''
+  }
+
   constructor(private dt: DateTime) {}
 
   public get isValid() {