fix(error): can handle `// => *Error

azu · Aug 30, 2016 · 95babac · 95babac
1 parent 05624b0
commit 95babac
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/src/ast-utils.js b/src/ast-utils.js
@@ -41,10 +41,10 @@ function extractionBody(ast) {
 export function wrapAssert(actualNode, expectedNode) {
     assert(typeof expectedNode !== "undefined");
     var type = expectedNode.type || extractionBody(expectedNode).type;
-    if (type === Syntax.Identifier && expectedNode.name === "Error") {
+    if (type === Syntax.Identifier && /^[a-zA-Z]*?Error$/.test(expectedNode.name)) {
         return toAST`assert.throws(function() {
                     ${actualNode}
-               }, ${expectedNode})`;
+               })`;
     } else if (type === Syntax.Identifier && expectedNode.name === "NaN") {
         return toAST`assert(isNaN(${actualNode}));`;
     } else if (isConsole(actualNode)) {

diff --git a/test/comment-to-assert-test.js b/test/comment-to-assert-test.js
@@ -17,6 +17,21 @@ function parseToAST(code) {
 }
 describe("comment-to-assert", function() {
     describe("#toAssertFromSource", function() {
+        it("test", function() {
+
+            function sum(...values) {
+                return values.reduce((total, value) => {
+                    console.assert(Number.isFinite(value), `${ value }は有限数ではありません`);
+                    return total + Number(value);
+                }, 0);
+            }
+
+            var x = 1, y, z = 10;
+            assert.throws(function() {
+                sum(x, y, z);
+            }, Error);
+
+        });
         it("should return code", function() {
             var code = "var a = 1;";
             var result = toAssertFromSource(code, "file.js");
@@ -126,7 +141,7 @@ describe("comment-to-assert", function() {
             var result = toAssertFromAST(AST);
             var expected = `assert.throws(function() {
                 throw new Error("error");
-            }, Error);`;
+            });`;
             astEqual(result, expected);
         });
         it("could handle NaN", function() {