-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SimulationData type #14
Comments
|
A good starting point would be a type This should then be able to work as data object for |
We could make this an interface as well. Here some thoughts on the specs. getobs or getdata? getcoords (but how do we return the ys coords) dim |
This is nagging me for a long time and has caused a lot of headaches.
The main problem is that each of these can stand on their own, no clear hierarchy is obvious.
ISOKANN has its own trainings data, which however can differ from the full "coordinate" data.
For visualization however it needs access to the "coordinate" data.
Adaptive sampling complicates this further.
One way of patching them together is via a DataLoader which doubles as data provider for ISOKANN but also holds raw data, and is able to also contain a Simulation.
Where do we attach known reaction coordinates (for visualization) etc?
The text was updated successfully, but these errors were encountered: