Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-sns-sqs): added sqsSubscriptionProps #700

Merged
merged 3 commits into from
May 24, 2022
Merged

Conversation

mickychetta
Copy link
Contributor

Issue #695 , if available:

Description of changes:

  • Added sqsSubscriptionProps to allow deadLetterQueue, filterPolicy, and rawMessageDelivery
  • Created unit and integration tests to check DLQ, filter policy, and raw message delivery

Notes:

  • sqsSubscriptionProps dead letter queue does not conflict with construct created SQS dead letter queue as they come from two different sources
    • SNS DLQ: Captures messages that can't be delivered to subscribers successfully
    • SQS DLQ: If a message can't be consumed successfully, it'll be sent to this dead-letter queue
  • sqsSubscriptionProps is only applicable for this construct as it is for this very specific use case of SQS subscribing to SNS
  • A possibility in the future is to implement lambdaSubscriptionProps for aws-sns-lambda
  • If no override is provided in sqsSubscriptionProps, we stick to the CDK defaults: no DLQ, no filter policy (all messages are delivered), and rawMessageDelivery: false

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

fixes #695

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: f07e90e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: f07e90e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 195c224
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: 195c224
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 854f73d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: 854f73d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@biffgaut biffgaut merged commit bcc1216 into awslabs:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Raw Message Delivery parameter to aws-sns-sqs Module
3 participants