feat(aws-dynamodbstreams-lambda-elasticsearch-kibana) created new construct #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port new construct
…-kibana for jsii error
mickychetta
requested review from
biffgaut,
hayesry and
hnishar
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was
linked to
issues
Aug 10, 2021
biffgaut
requested changes
Aug 10, 2021
| handler: 'index.handler' | ||
| }, | ||
| domainName: 'test-domain', | ||
| // TODO: Ensure the Cognito domain name is globally unique |
There was a problem hiding this comment.
Oops - didn't know this was out there. I guess I should put this in our backlog at least...
(not an issue for this task though)
|
|
||
|  | ||
| > Some of our early constructs don’t meet the naming standards that evolved for the library. We are releasing completely feature compatible versions with corrected names. The underlying implementation code is the same regardless of whether you deploy the construct using the old or new name. We will support both names for |
There was a problem hiding this comment.
This looks like a cut and paste error?
|
|
||
| ## Lambda Function | ||
|
|
||
| This pattern requires a lambda function that can post data into the Elasticsearch from DynamoDB stream. A sample function is provided [here](/~https://github.com/awslabs/aws-solutions-constructs/blob/master/source/patterns/%40aws-solutions-constructs/aws-dynamodbstreams-lambda-elasticsearch-kibana/test/lambda/index.js). |
There was a problem hiding this comment.
Great catch to point this to the Lambda function under the new construct! I missed this on the first read and had to come back to check when it occurred to me later.
biffgaut
approved these changes
Aug 10, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #293 #294 , if available:
Description of changes:
-Created new construct aws-dynamodbstreams-lambda-elasticsearch-kibana
-Added wrapper in aws-dynamodb-stream-lambda-elasticsearch-kibana to support aws-dynamodbstreams-lambda-elasticsearch-kibana
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.