Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Build and test on Windows. #290

Closed
wants to merge 2 commits into from

Conversation

jeffdav
Copy link

@jeffdav jeffdav commented Oct 3, 2024

Issue #, if available: #289

Description of changes:

  • Add posix and bsd paths to excludes for Windows.
  • Define AWS_OS_WINDOWS_DESKTOP and AWS_USE_IO_COMPLETION_PORTS for Windows.
  • Fix some type casts between Int32 <--> UInt32 that cause errors on Windows.
  • Remove non-existent exclude path (silences a useless warning).
  • Explicitly use Foundation.UUID where needed to avoid confusion with Windows SDK UUID.
  • Add setenv/unsetenv shim for tests on Windows.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeffdav
Copy link
Author

jeffdav commented Oct 3, 2024

Still has two build issues:

  1. When building AwsCommonRuntimeKit, the aws-c-cal header opensslcrypto_common.h is picked up by the clang importer, even though it's excluded in Package.swift. I fixed this locally by putting #if _MSC_VER around the whole header. I think the proper fix is to provide a module.modulemap file in aws-c-cal.
  2. When building AwsCommonRuntimeKit, the aws-c-common module fails to find GetConsoleMode(), despite including windows.h, which the documentation says should be enough. I fixed it locally by including consoleapi.h as well.

Since these issues are in submodules, they may need to be fixed first, but I'd love feedback.

Also some tests fail, but I think that's because I just don't have the local environment setup correctly.

@jeffdav jeffdav changed the title Jeff/windows fixes [Windows] Build and test on Windows. Oct 3, 2024
@jeffdav
Copy link
Author

jeffdav commented Oct 10, 2024

I'm going to close this for now, since it's just a POC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant