Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add region validation using DNS Host label regex #1402

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 28, 2020

Issue #, if available:
From v2: aws/aws-sdk-js#3368
Internal issue JS-1834

Description of changes:
adds region validation using DNS Host label regex

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1402 into master will increase coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
+ Coverage   79.08%   79.48%   +0.40%     
==========================================
  Files         287      296       +9     
  Lines       11155    11388     +233     
  Branches     2360     2434      +74     
==========================================
+ Hits         8822     9052     +230     
- Misses       2333     2336       +3     
Impacted Files Coverage Δ
...dential-provider-imds/src/fromContainerMetadata.ts
...edential-provider-imds/src/remoteProvider/retry.ts
...al-provider-imds/src/remoteProvider/httpRequest.ts
...rovider-imds/src/remoteProvider/ImdsCredentials.ts
...ider-imds/src/remoteProvider/RemoteProviderInit.ts
...edential-provider-imds/src/fromInstanceMetadata.ts
...provider-imds/dist/cjs/src/fromInstanceMetadata.ts 100.00% <0.00%> (ø)
packages/is-array-buffer/dist/cjs/src/index.ts 100.00% <0.00%> (ø)
packages/util-buffer-from/dist/cjs/src/index.ts 100.00% <0.00%> (ø)
...eProvider/src/remoteProvider/RemoteProviderInit.ts 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e03c974...9ef0bc6. Read the comment docs.

@trivikr trivikr merged commit 88e96e6 into aws:master Jul 28, 2020
@trivikr trivikr deleted the add-region-validation branch July 28, 2020 20:47
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants