Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK's hostname validation to allow port similar to v1 SDK. #1035

Closed
jasdel opened this issue Jan 13, 2021 · 2 comments · Fixed by aws/smithy-go#279
Closed

Update SDK's hostname validation to allow port similar to v1 SDK. #1035

jasdel opened this issue Jan 13, 2021 · 2 comments · Fixed by aws/smithy-go#279
Labels
bug This issue is a bug.

Comments

@jasdel
Copy link
Contributor

jasdel commented Jan 13, 2021 •
edited
Loading

Describe the bug
The SDK should allow endpoints with ports to be specified. The endpoint validation for hostname does not allow this.

V1 issue: aws/aws-sdk-go#3730

Version of AWS SDK for Go?
v0.31.0

Version of Go (go version)?
v1.15.6
@jasdel jasdel added the bug This issue is a bug. label Jan 13, 2021
@jasdel jasdel mentioned this issue Mar 31, 2021
Merged
@jasdel
Copy link
Contributor Author

jasdel commented Mar 31, 2021

This will be fixed by aws/smithy-go#279

@github-actions
Copy link

github-actions bot commented Apr 7, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

transport/http : Loosen hostname validation to allow ports to be specified skotambkar/smithy-go
1 participant
@jasdel