feat: add typescript support via typings file #83
Conversation
|
Resolves #81 |
robinhood.d.ts
Outdated
| * @param code | ||
| * @param callback | ||
| */ | ||
| set_mfa_code (code: string, callback: InitCallback): void |
There was a problem hiding this comment.
This is referenced in the docs but is not in the code I see in master. Should it be here or removed?
There was a problem hiding this comment.
We should either remove it from here or add it back in the code if there is still support for it I suppose
There was a problem hiding this comment.
Gotcha. I can remove for now and can add back if it changes.
robinhood.d.ts
Outdated
| Day = 'day' | ||
| } | ||
|
|
||
| enum TriggerTypes { |
There was a problem hiding this comment.
I am going to open an issue for this, but I think TimeInForceTypes and TriggerTypes are reversed according to /~https://github.com/sanko/Robinhood/blob/master/Order.md and the tests that I was doing the other day. Side note - I wish 'ioc' time_in_force worked but maybe Robinhood deprecated it because I was getting invalid value.
There was a problem hiding this comment.
@chiefsmurph you're correct, not sure how I managed that! I can address this later PDT.
There was a problem hiding this comment.
Let me know when this is ready to merge and I'll release a new version with it
|
@aurbano this is ready now. The MFA references are removed until the authentication stuff is resolved - I'll gladly PR it back when required. The README might also need an update since it still references it. |
|
@evanshortiss awesome I'll merge, edit the README and release a new version with it 😄 |
|
Thanks @aurbano |
This will add support for typescript users and (I believe) should also add improved intellisense for JS users in VSCode.
I added the
.editorconfigfile since my editor was defaulting to 4 spaces whereas the project seems to use 2. The.editorconfigwill help enforce that.