Add validation for orientation of initial pose #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#795] PASSED on melodicAll tests passed[#795] PASSED on kineticAll tests passed |
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
==========================================
- Coverage 94.34% 94.24% -0.11%
==========================================
Files 32 32
Lines 1645 1651 +6
==========================================
+ Hits 1552 1556 +4
- Misses 93 95 +2
Continue to review full report at Codecov.
|
at-wat
reviewed
May 27, 2020
src/mcl_3dl.cpp
Outdated
| msg->pose.pose.orientation.w * msg->pose.pose.orientation.w; | ||
| if (std::abs(len2 - 1.0) > 0.1) | ||
| { | ||
| ROS_ERROR("Invalid pose is set. The orientation must be unit quaternion."); |
There was a problem hiding this comment.
what about
Suggested change
| ROS_ERROR("Invalid pose is set. The orientation must be unit quaternion."); | |
| ROS_ERROR("Discarded invalid initialpose. The orientation must be unit quaternion."); |
|
@at-wat Addressed your comment. PTAL. The CI failed due to rosdep related problem. |
Official ROS docker image seems broken. |
|
ros-infrastructure/rosdep#745 |
[#803] PASSED on melodicAll tests passed[#803] FAILED on kineticTest failed[#803] PASSED on kineticAll tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #316