Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Object.assign is not defined for older browsers (e.g. IE 11) #141

Closed
pencilcheck opened this issue May 24, 2017 · 3 comments
Closed

Object.assign is not defined for older browsers (e.g. IE 11) #141

pencilcheck opened this issue May 24, 2017 · 3 comments

Comments

@pencilcheck
Copy link

return Object.assign(networkInterface, {

Getting error when running inside older browsers using the library.

@mistic
Copy link
Contributor

mistic commented May 25, 2017

Maybe we can move from Object.assign to the lodash.cloneDeep. What do u think @DxCx @Urigo @NeoPhi ?

@NeoPhi
Copy link
Contributor

NeoPhi commented May 25, 2017

We should pull in an use the 'object-assign' library. This is the one that react-apollo uses. We definitely shouldn't switch to a deep cloning.

@mistic
Copy link
Contributor

mistic commented May 25, 2017

Lol ( @NeoPhi @DxCx ) I was almost sleeping when I wrote this! What I meant was lodash.assign and not cloneDeep. As react-apollo already uses the 'object-assign' maybe we can also use it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants