Reduces hierarchies of if-expression

apache · Jan 10, 2022 · 3e3c7bb · 3e3c7bb
1 parent 030d322
commit 3e3c7bb
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/superset/dashboards/filter_state/commands/get.py b/superset/dashboards/filter_state/commands/get.py
@@ -26,12 +26,9 @@
 class GetFilterStateCommand(GetKeyValueCommand):
     def get(self, resource_id: int, key: str, refresh_timeout: bool) -> Optional[str]:
         dashboard = DashboardDAO.get_by_id_or_slug(str(resource_id))
-        if dashboard:
-            entry: Entry = cache_manager.filter_state_cache.get(
-                cache_key(resource_id, key)
-            )
-            if entry:
-                if refresh_timeout:
-                    cache_manager.filter_state_cache.set(key, entry)
-                return entry["value"]
-        return None
+        entry: Entry = cache_manager.filter_state_cache.get(
+            cache_key(resource_id, key)
+        ) or {}
+        if dashboard and entry and refresh_timeout:
+            cache_manager.filter_state_cache.set(key, entry)
+        return entry.get("value")