This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Revert "Image normalize operator - GPU support, 3D/4D inputs (#13802)" #14054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
PR with the fix - #14055 |
|
Closing this PR in favor of the fix - #14055 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3a1a80a.
Description
This PR is to revert #13802 where we added a normalize operator with batch support, gpu support and restructured to use kernel launch/map method.
I observed a performance drop in normalize operator on CPU:
Before the change:
Total time for 50000 (3,300,300) normalization - 67.39s
After the change:
Total time for 50000 images of shape (3,300,300) to do normalization - 104.09s
I am working on the fix. This PR is stop gap in case the performance fix PR is delayed.
@nswamy