-
Notifications
You must be signed in to change notification settings - Fork 272
feat(legacy-plugin-chart-markup): add controls to markup chart #479
feat(legacy-plugin-chart-markup): add controls to markup chart #479
Conversation
This pull request is being automatically deployed with Vercel (learn more). π Inspect: https://vercel.com/superset/superset-ui/oi6jpdekm |
import { validateNonEmpty } from '@superset-ui/validator'; | ||
import { formatSelectOptions } from '@superset-ui/control-utils'; | ||
|
||
console.log('what are going on with these controls') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove console.log
], | ||
}, | ||
], | ||
sectionOverrides: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this section needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kristw I think they are needed (or at least relevant). There are a few plugins that do this... iframe, markup, and separator. It appears this basically removes the time_range
control that's seemingly injected automatically in some cases as part of the druidTimeSeries
. Maybe we can find a better way of addressing this in the future, but it seems out of the scope of this PR, which is just to migrate the code that's there already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
+ Coverage 22.36% 22.38% +0.01%
==========================================
Files 266 271 +5
Lines 6549 6563 +14
Branches 605 608 +3
==========================================
+ Hits 1465 1469 +4
- Misses 5047 5057 +10
Partials 37 37
Continue to review full report at Codecov.
|
π Breaking Changes
π Enhancements
Add controls to markup chart plugin.
π Documentation
π Bug Fix
π Internal