This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(dimension): set width=0, height=0 in createHiddenSvgNode
#261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This fixes an issue in
@superset-ui/dimensions
where the hiddensvg
used for text measurement has a non-zerowidth/height
, and can result in thesvg
affecting layout even though it hasposition: absolute
. In our case this actually causes an infinite measurement loop wheresvg
is added, resulting in a browser scroll barsvg
is removed, making the scroll bar go away2)
from the scroll bar going away triggers the ResizeObserver of a parent component, updating the chart and goes back to1)
I updated it to mirror what we have in
@vx/text
which was fixed here.@kristw