This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(dccd): fix DirtyCheckingRecord.toString() throws an exception
closes #1057
- Loading branch information
efcdca3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vicb; any ideas for testing this bug?
efcdca3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbdeboer I think there is no easy way to test with without refactoring - ie we can test the current
_mode
s but there is no way to automatically pick new (or deleted)_modes
.I'll make the code more robust by making sure the
_mode
has a name before trying to print it. Still it could print a wrong name but I'm not sure it deserve to be unit tested (I'm not in favor of testing such things).efcdca3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbdeboer see 47ad9d9