More fixes to GitHub Actions (#4106)

* More fixes to GitHub Actions

* report code coverage from GH Actions

* add token

* try again

* add comment about codecov failures

.github/workflows/checks.yml

@@ -56,17 +56,18 @@ jobs:
       run: |
         make test-with-cov
 
-    # TODO: remove codecov report publishing from TeamCity build and then uncomment this:
-    # - name: Upload coverage to Codecov
-    #   if: matrix.python == '3.7'
-    #   run: |
-    #     # Ignore codecov failures as the codecov server is not
-    #     # very reliable but we don't want to report a failure
-    #     # in the github UI just because the coverage report failed to
-    #     # be published.
-    #     codecov || echo "codecov upload failed"
-    #   env:
-    #     CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+    - name: Upload coverage to Codecov
+      if: matrix.python == '3.7'
+      env:
+        CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+      run: |
+        # Ignore codecov failures as the codecov server is not
+        # very reliable but we don't want to report a failure
+        # in the github UI just because the coverage report failed to
+        # be published.
+        # This will also fail for forked repositories since the secret token won't
+        # be available.
+        codecov -t $CODECOV_TOKEN || echo "codecov upload failed"
 
   models:
     runs-on: ubuntu-latest

.github/workflows/docs.yml

@@ -71,6 +71,7 @@ jobs:
         ssh-keyscan github.com >> ~/.ssh/known_hosts
         
         # Checkout allennlp-docs to /allennlp-docs
+        mkdir -p /ssh
         echo $DOCS_DEPLOY_KEY > /ssh/allennlp-docs.key
         ssh-add /ssh/allennlp-docs.key
         GIT_SSH_COMMAND='ssh -i /ssh/allennlp-docs.key' git clone git@github.com:allenai/allennlp-docs.git /allennlp-docs