This repository has been archived by the owner on May 30, 2022. It is now read-only.
add comments to make springboot can give tips to users #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leizhiyuan
requested review from
ujjboy,
NeGnail,
khotyn and
JervyShi
and removed request for
ujjboy,
NeGnail and
khotyn
JervyShi
suggested changes
Feb 11, 2019
update sofaboot version to fix snapshot |
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
========================================
Coverage 57.8% 57.8%
Complexity 433 433
========================================
Files 56 56
Lines 1806 1806
Branches 318 318
========================================
Hits 1044 1044
Misses 554 554
Partials 208 208
Continue to review full report at Codecov.
|
JervyShi
approved these changes
Feb 11, 2019
leizhiyuan
changed the title
khotyn
suggested changes
Feb 11, 2019
| private Map<String, String> registries = new HashMap<String, String>(); | ||
|
|
||
| //mesh switch,can be protocol,like bolt,mesh,all,now we only support bolt | ||
| /** | ||
| * enable mesh，an be protocol,like bolt,mesh,all,now we only support bolt （是否开启mesh支持，目前只支持bolt） |
…a-rpc-boot-projects into add_comment_to_springboot
khotyn
approved these changes
Feb 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
thanks for @chpengzh
if write comments as javadoc, spring-boot-configuration-processor will generate descriptions, like this.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.