Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TermUI.prompt() does not work in JS #387

Closed
championswimmer opened this issue Dec 28, 2022 · 2 comments · Fixed by #388
Closed

TermUI.prompt() does not work in JS #387

championswimmer opened this issue Dec 28, 2022 · 2 comments · Fixed by #388

Comments

@championswimmer
Copy link

In JS, the file execution never returns after the prompt() call back to the main thread where it was called from.

(some internal await / callback issue maybe)
@championswimmer
Copy link
Author

AFAI can tell something definitely wrong with this

/~https://github.com/ajalt/clikt/blob/master/clikt/src/jsMain/kotlin/com/github/ajalt/clikt/output/CliktConsoleJS.kt#L22-L28

@championswimmer
Copy link
Author

Using the Kotlin "IR" compiler, buffer.toString() does not work correctly.

@ajalt ajalt mentioned this issue Jan 7, 2023
Merged
@ajalt ajalt closed this as completed in #388 Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix promptForInput on NodeJs target ajalt/clikt
1 participant
@championswimmer