feat: ignore and replace flags

aidenybai · Nov 1, 2021 · 36710da · 36710da
1 parent b0f9525
commit 36710da
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 33 deletions.
diff --git a/package.json b/package.json
@@ -81,7 +81,7 @@
     "@types/glob": "^7.2.0",
     "@types/jest": "^27.0.2",
     "@types/node": "^16.11.6",
-    "@typescript-eslint/eslint-plugin": "^5.2.0",
+    "@typescript-eslint/eslint-plugin": "^5.3.0",
     "@typescript-eslint/parser": "^4.33.0",
     "benchmark": "^2.1.4",
     "eslint": "^8.1.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/__test__/patch.test.ts b/src/__test__/patch.test.ts
@@ -212,11 +212,4 @@ describe('.patch', () => {
 
     expect(el2).toEqual(document.createElement('a'));
   });
-
-  it('should return el if ignore is set', () => {
-    const el1 = createElement(m('div', { ignore: true }));
-    const el2 = patch(el1, m('a'));
-
-    expect(el2).toEqual(el1);
-  });
 });
diff --git a/src/drivers/children.ts b/src/drivers/children.ts
@@ -30,6 +30,13 @@ export const childrenDriver =
       workStack,
     };
 
+    if (newVNode.flag === VFlags.IGNORE_NODE) return data;
+
+    if (newVNode.flag === VFlags.REPLACE_NODE) {
+      el.replaceWith(createElement(newVNode));
+      return data;
+    }
+
     const oldVNodeChildren: VNode[] = oldVNode?.children ?? [];
     const newVNodeChildren: VNode[] | undefined = newVNode.children;
     const delta: VDelta | undefined = newVNode.delta;

diff --git a/src/patch.ts b/src/patch.ts
@@ -53,7 +53,6 @@ export const compose =
       if (!hasString) {
         const oldVElement = <VElement>prevVNode;
         const newVElement = <VElement>newVNode;
-        if (oldVElement?.props?.ignore || newVElement?.props?.ignore) return finish(el);
         if (
           (oldVElement?.key === undefined && newVElement?.key === undefined) ||
           oldVElement?.key !== newVElement?.key

diff --git a/src/types/base.ts b/src/types/base.ts
@@ -36,6 +36,8 @@ export enum VFlags {
   ONLY_TEXT_CHILDREN = 1,
   ONLY_KEYED_CHILDREN = 2,
   ANY_CHILDREN = 3,
+  REPLACE_NODE = 4,
+  IGNORE_NODE = 5,
 }
 
 export const enum VDeltaOperationTypes {