fix: use injected acorn instance

[pemrouz]

Since rollup bundles it's own version of acorn, require("acorn") will never be the same as Parser.acorn and you always gets the error "acorn-private-class-elements does not support mixing different acorn copies". If this change looks good, I can make a similar one for acorn-class-fields (and also bump it to use latest version of this module).

[coreyfarrell]

I think this check needs to be changed to simply if (!acorn) {. For versions older than 6.4.0 or 7.1.0 Parser.acorn is undefined. In this case the peerDependency in package.json needs to be updated to ^6.4.0 || ^7.1.0.

Alternatively the line before could be const acorn = Parser.acorn || require('acorn') - this would maintain compatibility with all versions of acorn currently allowed by the peerDependency. If this were done then the check Parser being from the same acorn as tt would need to be restored.

As I'm not a maintainer of this module I cannot say which change is prefered, I can only say the current version check will not give the expected error, it will simply fail on read of acorn.version when acorn is undefined.

[adrianheine]

I would prefer @coreyfarrell's (second) suggestion.

[adrianheine]

If you plan to implement that, please also consider #13 :)

[yangwao]

Would like to see this merged, prolly could help me out ezolenko/rollup-plugin-typescript2#217 🤔

[0biWanKenobi]

in rollup, meanwhile, you can do this evil thing:

step 1:

const acorn = require("acorn")

const myAcornPlugin = () => {
    return acorn.Parser
}

step 2, within acorn config:

...
  acornInjectPlugins: [ myAcornPlugin, acornPrivateFields ],
...

[LongTengDao]

in rollup, meanwhile, you can do this evil thing:

step 1:

const acorn = require("acorn")

const myAcornPlugin = () => {
    return acorn.Parser
}

step 2, within acorn config:

...
  acornInjectPlugins: [ myAcornPlugin, acornPrivateFields ],
...

@0biWanKenobi Great solution!

I had handly rmdir the node_modules of acorn-class-fields, acorn-private-methods and acorn-static-class-features to force them depend on acorn-private-class-elements v0.2.0 to resolve the version error, but the mix error stuck me.

Thank you!

[adrianheine]

I just published 0.2.3 with 4cab928. Thanks for your work!