RSL4 #96
Merged
RSL4 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(message.content() as? NSObject).to(equal(fixtureMessage["data"].object as? NSObject)) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // RSL4a | ||
| it("RSL4a") { |
There was a problem hiding this comment.
@mattheworiordan What do you think? I need to add something to check the sent data.
|
Really good progress, however we need to get the tests passing now as opposed to moving on and leaving more TODO / FIXME items in the list. |
Closed
|
Thanks, looks very good, few small comments, but 👍 |
|
Needs #122. |
RSL4d3 is unfinished because the payload is different from the expected behaviour
- Ignore comment
- Avoid comparing the JSON string because `NSJSONSerialization` could change the arguments order.
|
Rebased |
|
Ok, have the comments been addressed? Hard to tell as old history is gone, if so, I think we should merge. @tcard do you agree? |
|
Yes, all comments addressed. |
|
@tcard please merge if you are happy then |
| @@ -317,6 +326,9 @@ - (ARTStatus *)decode:(ARTPayload *)payload output:(ARTPayload *__autoreleasing | |||
|
|
|||
| @end | |||
|
|
|||
|
|
|||
| // MARK: Cipher | |||
There was a problem hiding this comment.
It helps with the Show Document Items:
|
Aside from @tcard's feedback, looks good |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.