Xcode 10 minimal support #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funkyboy
approved these changes
Oct 11, 2018
| @@ -11,6 +11,7 @@ matrix: | |||
| - env: NAME="ably-iOS" LANE=test_iOS9 | |||
| before_install: | |||
| - gem install cocoapods -v '1.5.3' | |||
| - pod repo update > /dev/null | |||
There was a problem hiding this comment.
Oh good, this will also unlock the pending ULID PR
|
@funkyboy Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't use Xcode 9 to run tests anymore 😩 The Could not attach to pid is ruining my day. I tried many things and nothing fixed it.
But I can run tests using in Xcode 10 🤷♂️ So I did just the minimal changes to be able to work with Xcode 10.
@funkyboy Could you use this in your
xcode10-ios12-swift42branch? Sorry, I tried to use yours but you have so many changes that I preferred to create mine with little changes.