Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTN16f #801

Merged
merged 6 commits into from
Sep 21, 2018
Merged

RTN16f #801

merged 6 commits into from
Sep 21, 2018

Conversation

ricardopereira
Copy link
Contributor

@ricardopereira ricardopereira commented Sep 21, 2018 •
edited
Loading

(RTN16f) The msgSerial component of the recoveryKey, unlike the other two components, is not sent to Ably, but rather is used to set the library internal msgSerial. (If the recover fails, the counter should be reset to 0 per RTN15c3)
https://docs.ably.io/client-lib-development-guide/features/#RTN16f

paddybyers
paddybyers approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ricardopereira ricardopereira merged commit 41a815b into update-rtn16b Sep 21, 2018
@ricardopereira ricardopereira deleted the rtn16f branch September 21, 2018 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardopereira @paddybyers