RTN23

[ricardopereira]

#638

[SimonWoolf]

👍 Looks good. (One thought: could maybe have a quick test that client.maxIdleInterval is 15 for the simulated connection which sets it to 15000 in the connectionDetails, to check that it's being converted from milliseconds to seconds).

FWIW: The approach you've gone with here is what I did in ably-js at first. I later changed it to one that just records the last activity time (and only sets a new timer at most every 15s) after Paddy noted that the initial way was quite expensive. The new way gives the additional advantage that you can use the lastActivity time for the connection state freshness check in #645 . Not saying you need to change approach to that now -- for the moment, better to get this out as-is -- but something to keep in mind as a possibility when you implement #645 .

[mattheworiordan]

LGTM 👍