RSC7a #483
RSC7a #483
Conversation
| fail("X-Ably-Version header not found"); done() | ||
| return | ||
| } | ||
| expect(headerAblyVersion) == ARTDefault.version() |
There was a problem hiding this comment.
Whilst I appreciate this test is accurate, I think it would be useful to in fact be a more explicit and expect 0.8 for example in the string. I appreciate when we upgrade to 0.9 it will break, but personally I like that as the test expectation has broken. For example, if someone mistakenly upgrade to 0.99, this test would continue to pass
There was a problem hiding this comment.
@mattheworiordan There is already a G4 /~https://github.com/ably/ably-ios/blob/b3fdead2e828bf472bc51f3364e4118b8459b817/Spec/RestClient.swift#L32.
The current test is verifying if the client conforms with defaults.
There was a problem hiding this comment.
Fine, thanks for clarifying
|
LGTM, @mattheworiordan please confirm you're OK with having the explicit test at a single place as @ricardopereira says. |
|
@tcard happy for it to be merged |
No description provided.