Add MessagePack support. #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make it the default.
|
@mattheworiordan Please confirm I should merge this and #446, I should really make a new release. |
|
Looks good. Shame we don't have more permutations of tests with / without the binary protocol, but I think this should prove it works sufficiently for now. I was not entirely clear when reviewing, but do you have any tests using MsgPack over REST as well? |
|
@mattheworiordan All the tests that weren't JSON-specific before are now using MessagePack, because it's the new default. So yes, most REST tests use MessagePack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make it the default.