RTN17a #387
Merged
RTN17a #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardopereira
force-pushed
the
rtn17a
branch
2 times, most recently
from
e601bbc to
aa6459b
Compare
|
To be revisited after #385 is merged. |
|
👍 |
Merged
|
PTAL |
|
👍 |
tcard
force-pushed
the
rtn17a
branch
2 times, most recently
from
1cc014e to
dac8926
Compare
|
The fix used to pass but now it crashes, I guess because of some conflict with what got merged to master in the meantime. I'll merge this and #388, #390, #444 and #406 just with pending tests, without the fixes, and then do a separate PR fixing all of them together, to avoid conflicting fixes between them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.