RTP1 #282
Merged
RTP1 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(channel.presenceMap.isSyncComplete()).to(beFalse()) | ||
| } | ||
|
|
||
| it("when members are present") { |
There was a problem hiding this comment.
This tests when one member is present. Spec says "subsequent ProtocolMessage SYNC messages will be delivered", which requires a test that expects more then one SYNC messages to arrive and be processed properly.
There was a problem hiding this comment.
I would agree, please add 250 present members, and expect 3 SYNC pages of members.
There was a problem hiding this comment.
Done d6a47ec.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.