Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSN4: releaseChannel #268

Merged
merged 2 commits into from
Mar 2, 2016
Merged

Fix RSN4: releaseChannel #268

merged 2 commits into from
Mar 2, 2016

Conversation

ricardopereira
Copy link
Contributor

No description provided.

@ricardopereira ricardopereira force-pushed the fix-RSN4 branch 3 times, most recently from 1a26d4f to 3640831 Compare March 2, 2016 00:09
@tcard
Copy link
Contributor

tcard commented Mar 2, 2016

I don't understand why this wasn't working, it definitely was working before (#222 shows green). Anyway, LGTM.

@ricardopereira
Copy link
Contributor Author

Before this change, the channel, sometimes or most of the times, was released when the test goes off. The release implementation was always correct.

ricardopereira added a commit that referenced this pull request Mar 2, 2016
Fix RSN4: releaseChannel
@ricardopereira ricardopereira merged commit f06bda9 into master Mar 2, 2016
@ricardopereira ricardopereira deleted the fix-RSN4 branch March 2, 2016 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants