Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTN12b #162

Merged
merged 3 commits into from
Jan 27, 2016
Merged

RTN12b #162

merged 3 commits into from
Jan 27, 2016

Conversation

ricardopereira
Copy link
Contributor

Not passing. The realtimeRequestTimeout is not used, so... feature not implemented.

case .Closed:
end = NSDate()
states += [state]
case .Disconnected:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should this happen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not happen but I want to catch it and check if states doesn't have a .Disconnected event.

@ricardopereira
Copy link
Contributor Author

Rebased with changes.

The realtimeRequestTimeout is not used, so... feature not implemented.

@mattheworiordan
Copy link
Member

LGTM

1 similar comment
@tcard
Copy link
Contributor

tcard commented Jan 27, 2016

LGTM

ricardopereira added a commit that referenced this pull request Jan 27, 2016
@ricardopereira ricardopereira merged commit 2aadfe3 into master Jan 27, 2016
@ricardopereira ricardopereira deleted the RTN12b branch January 27, 2016 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants