Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ably-ios ws spec breach: closing websockets with reserved close codes #605

Closed
SimonWoolf opened this issue May 17, 2017 · 0 comments
Closed

ably-ios ws spec breach: closing websockets with reserved close codes #605

SimonWoolf opened this issue May 17, 2017 · 0 comments
Assignees
@ricardopereira
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@SimonWoolf
Copy link
Member

Apparently ably-ios sometimes closes the websocket with code 1006.

This is a breach of the spec, see https://tools.ietf.org/html/rfc6455 page 45: "1006 is a reserved value and MUST NOT be set as a status code in a Close control frame by an endpoint". (It's the value displayed when a websocket closed without sending a close frame at all).

This has been causing "Error: invalid error code" exceptions on the backend.
@SimonWoolf SimonWoolf added the bug Something isn't working. It's clear that this does need to be fixed. label May 17, 2017
@ricardopereira ricardopereira mentioned this issue May 18, 2017
Merged
@tcard tcard closed this as completed May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardopereira ricardopereira

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tcard @ricardopereira @SimonWoolf