Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.9 spec: Extras field #552

Closed
SimonWoolf opened this issue Dec 5, 2016 · 4 comments
Closed

0.9 spec: Extras field #552

SimonWoolf opened this issue Dec 5, 2016 · 4 comments

Comments

@SimonWoolf
Copy link
Member

ably/docs#203
@mattheworiordan
Copy link
Member

@tcard is this not implemented already? Can we close this issue?

@tcard
Copy link
Contributor

tcard commented Jul 6, 2017

No, suprisingly it isn't, neither in master nor in the push branch. I'll do it now.

tcard added a commit that referenced this issue Jul 6, 2017
@tcard
Add extras field to Message.
e8f9314 
Fixes #552.
@tcard tcard mentioned this issue Jul 6, 2017
Merged
@mattheworiordan
Copy link
Member

nor in the push branch

If it's not in the push branch, how could push even work from the library itself? I assume it didn't right?

tcard added a commit that referenced this issue Jul 10, 2017
@tcard
Add extras field to Message. (#617)
dc8b10e 
Fixes #552.
@tcard
Copy link
Contributor

tcard commented Jul 10, 2017

If you mean how could you send push notifications from the library, you could use rest.push.publish, but yes, it had incomplete support. I'm not sure how we overlooked this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattheworiordan @tcard @SimonWoolf