fix: staking now shows when no wallet attached #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incentive helper is now optional
sakulstra
commented
Nov 11, 2021
| preferredConnectionMode === ConnectionMode.rpc || network !== apolloClientNetwork | ||
| preferredConnectionMode === ConnectionMode.rpc || | ||
| network !== apolloClientNetwork || | ||
| !networkConfig.addresses.uiIncentiveDataProvider |
There was a problem hiding this comment.
not happy with that fix, when i have some time i'll look into redoing the dataflow.
It's kinda nutzs that we go soo deep down the dom just to set a boolean skip flag because there's no address set
| userAddress: string = ethers.constants.AddressZero, | ||
| helperAddress: string | ||
| ) => { | ||
| const loadStakeData = async (_userAddress: string | undefined, helperAddress: string) => { |
There was a problem hiding this comment.
useraddress is not undefined, but an empty string if not set so this default value doesn't work
sendra
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incentive helper is now optional