Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

pv 1.7.18 doesn't use the whole terminal width #72

Closed
andrew-schulman opened this issue Jul 30, 2023 · 4 comments
Closed

pv 1.7.18 doesn't use the whole terminal width #72

andrew-schulman opened this issue Jul 30, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@andrew-schulman
Copy link

In Cygwin, the output of pv 1.7.18 is always 80 characters wide, even when the terminal is wider, for example 199 columns as here:

$ pv -S -s 100G < /dev/zero > /dev/null
 100GiB 0:00:11 [8.73GiB/s] [================================>] 100%

$ echo $COLUMNS
199

pv 1.7.0 does use the whole terminal width in Cygwin.

@a-j-wood
Copy link
Owner

Confirmed that I can reproduce this on my own Cygwin installation using the example you have provided.

The fault appears to be caused by the configure and autoheader changes. In src/pv/display.c there is a check for "HAVE_TERMIOS_H", but this is no longer defined in config.h.

As a short term workaround, after running "configure", edit src/include/config.h and add

#define HAVE_TERMIOS_H 1

to the end of it, then run "make".

I have committed a fix to the main branch. If you would like to confirm that it works for you, please download the latest code (e.g. "git clone /~https://github.com/a-j-wood/pv.git") and then run "./generate.sh && ./configure && make". Thanks.

@a-j-wood a-j-wood added the bug Something isn't working label Jul 30, 2023
@andrew-schulman
Copy link
Author

Confirmed that the problem is fixed in main. Thanks! Once you make a new release I'll push it out to Cygwin.

@a-j-wood
Copy link
Owner

Thanks. A new release is imminent, since I expect that this fault was not confined only to the Cygwin platform.

@a-j-wood
Copy link
Owner

Version 1.7.24 now released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants