Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vditor 的生产代码未经 minify #1153

Closed
BeiyanYunyi opened this issue Jan 14, 2022 · 5 comments
Closed

vditor 的生产代码未经 minify #1153

BeiyanYunyi opened this issue Jan 14, 2022 · 5 comments
Assignees
@Vanessa219
Labels
改进功能
Milestone
3.8

Comments

@BeiyanYunyi
Copy link

BeiyanYunyi commented Jan 14, 2022 •
edited
Loading

编辑模式

  • wysiwyg 所见即所得模式
  • ir 即时渲染模式
  • sv 分屏编辑预览模式

描述问题

以 3.8.8 为例，发现代码仅仅被 bundle，却没有被 minify，连注释都还留着，从而带来了不必要的流量开销。

期待的结果

版本信息

  • 版本：3.8.8
  • 操作系统：Windows 11
  • 浏览器：Mozilla Firefox

其他信息

希望能检查一下 webpack 的配置。

图片
图为 3.8.8 版本的“min”代码，似乎没有被 minify 到。
@Vanessa219 Vanessa219 self-assigned this Jan 14, 2022
@Vanessa219 Vanessa219 added this to the 3.8 milestone Jan 14, 2022
@BeiyanYunyi
Copy link
Author

好耶！

@BeiyanYunyi
Copy link
Author

看了一下用的 terser，我记得 webpack5 的 minify 可以让它自己干

@Vanessa219
Copy link
Owner

欢迎PR

@BeiyanYunyi
Copy link
Author

好了，我是小丑。webpack 的 minify 本来就是 terser 干的。

@Vanessa219
Copy link
Owner

😊

This was referenced Jan 23, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
改进功能
Projects
None yet
Milestone
3.8
Development

No branches or pull requests
2 participants
@Vanessa219 @BeiyanYunyi