Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection of supported standards #14

Closed
GPMueller opened this issue Mar 19, 2018 · 5 comments
Closed

Improve detection of supported standards #14

GPMueller opened this issue Mar 19, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@GPMueller
Copy link
Contributor

See also https://stackoverflow.com/a/49367391/4069571

  • The test should be done without a file
  • The test should check a few known numbers (89, 03, 11, 14, 17, 20)
  • Numbers should be padded with zeros (currently 3 is checked, but 03 is not)
@GPMueller
Copy link
Contributor Author

GPMueller commented Mar 25, 2018

Implemented padding with 61db826.

@GPMueller GPMueller reopened this Mar 25, 2018
@GPMueller
Copy link
Contributor Author

Unfortunately the suggested solution to not use a file does not work so trivially with Python2...

@NOhs
Copy link
Collaborator

NOhs commented Mar 28, 2018

Quoting from the Readme

One compiler (Clang), one build system (written in Python)

I don't read: "One build system that supports every Python version there is, because we have to capture every possible scenario"

Therefore, dropping Python2 support seems to be a valid option to me. On Windows, most ppl have Python3 anyways via Anaconda I would guess. On modern Linux, python3 can be easily installed via the respective package manager. On Mac OSX I would also assume that python3 can be easily installed with homebrew or so. Therefore, I do not think dropping Python2 support is so dramatic.

@GPMueller
Copy link
Contributor Author

Only supporting Python3 from PR #23 onwards, where the proper detection of c++ dialects is implemented.

@GPMueller GPMueller added the enhancement New feature or request label Apr 19, 2018
@GPMueller
Copy link
Contributor Author

Merged with a7bbc88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants