Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate the Minigunner crush fix #130

Open
xezon opened this issue Aug 31, 2021 · 5 comments
Open

Re-evaluate the Minigunner crush fix #130

xezon opened this issue Aug 31, 2021 · 5 comments
Assignees
Labels
Controversial Is controversial Minor Severity: Minor < Major < Critical < Blocker Task A task for someone to work on

Comments

@xezon
Copy link
Collaborator

xezon commented Aug 31, 2021

Minigunner can now be crushed just like any other infantry unit. We should pay special attention to it and evaluate whether or not we keep it this way for the final release.

@xezon xezon added Task A task for someone to work on Controversial Is controversial labels Aug 31, 2021
@Madrageeeeee
Copy link

Think this is indeed a difficult one. In a way it also made sense that the elite infantry of the infantry general has extra features like this.

On the other hand it is quite annoying 😁

@xezon
Copy link
Collaborator Author

xezon commented Sep 10, 2021

We were thinking to test and adjust the crushing size. So we could make the China Minigunner harder to crush than regular infantry but not as extreme as before, where a car could almost drive through entirely.

@xezon xezon added the Minor Severity: Minor < Major < Critical < Blocker label Sep 17, 2021
@ReLaX82
Copy link

ReLaX82 commented Aug 14, 2022

Make them better crushable at least like Xezon said.

@xezon xezon self-assigned this Aug 15, 2022
@xezon
Copy link
Collaborator Author

xezon commented Aug 16, 2022

I looked into this with tweaking

  GeometryMajorRadius = xx
  GeometryMinorRadius = xx

in both Minigunner and Rocket Buggy.

Original

Here are original bounding boxes of some vehicles and Minigunner object. Rocket Buggy has more generous bounding box size relative to its physical mesh size.

boundingbox_original_1

boundingbox_original_2

Changed

Reducing bounding box values of Rocket Buggy to 1, 1 showed no visual difference in World Builder. The bounding box looked the same. As for Minigunner, reducing bounding box to 1, 1 showed difference, but no change in behaviour.

boundingbox_changed

Video

Crushing always looks like this, no matter the GeometryMajorRadius, GeometryMinorRadius. It is unclear to me whether or not this can be tweaked.

generals.2022-08-16.09-37-50-39.mp4

@xezon
Copy link
Collaborator Author

xezon commented Aug 16, 2022

Enlima29:

If it proofs that geometry change means nothing then probably it is also accounting the actual model size for the collision. Reminder that infantry have invisible modeled pickbox that is larger than their T-pose size as it allows them to be easily selectable, that also counts for their actual model size.

Zeke:

Yeah vehicles still have their actual model for geometry, meanwhile infantry only have their pickbox since space wrapped models have no actual geometry, it's also why infantry can't get 3d shadows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Controversial Is controversial Minor Severity: Minor < Major < Critical < Blocker Task A task for someone to work on
Projects
None yet
Development

No branches or pull requests

3 participants