Add default ids for listCellContentView and fix callout component ids #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gomay88
approved these changes
Mar 27, 2024
cbarcom
requested review from
alejandroruizponce and
DavidMarinCalleja
and removed request for
alexanegon and
alejandroruizponce
DavidMarinCalleja
requested changes
Mar 27, 2024
Co-authored-by: David <david.marin.calleja@telefonica.com>
DavidMarinCalleja
approved these changes
Mar 27, 2024
|
Screenshot tests report ✔️ All passing |
cbarcom
deleted the
task/IOS-9930-add-default-ListTableViewCell-id-fix-callout-ids
branch
amegias
added a commit
that referenced
this pull request
Apr 2, 2024
…callout component ids (#348) chore(Doc): Update pull_request_template.md (#349) fix(callout): Change spacing to match specification of 4px (#351) fix(Accessibility): Add accessibility identifier to dataCard elements (#347) feat(Accessibility): Add default and custom accessibility identifiers to Callout and DataCard refs IOS-9915 (#346)
tuentisre
pushed a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
IOS-9930
🥅 What's the goal?
List rows don't have default accessibility identifiers, so they have been assigned.
Also, according to Figma callout ids, they were incorrect and this PR fix them by removing section value from their id. Now,
DefaultAccessibilityIdentifier.Section will be optional.