Skip to content

Commit

Permalink
feat(Accessibility): IOS-9786 VIVO Novo app accessibility Assinaturas…
Browse files Browse the repository at this point in the history
…: decorative images/animation to ignore (#362)

* Skipped feedback icon from accessibility

* Skipped feedback icon form acccessibility in SwiftUI
  • Loading branch information
dhidalgofadrique authored Apr 29, 2024
1 parent 6dd44d3 commit 5325295
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
4 changes: 2 additions & 2 deletions Sources/Mistica/Components/Feedback/FeedbackView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public class FeedbackView: UIView {
icon.widthAnchor.constraint(equalToConstant: Constants.iconSize),
icon.heightAnchor.constraint(equalToConstant: Constants.iconSize)
])
icon.isAccessibilityElement = true
icon.isAccessibilityElement = false
icon.accessibilityIdentifier = DefaultIdentifiers.Feedback.asset
return icon
}()
Expand All @@ -78,7 +78,7 @@ public class FeedbackView: UIView {
animation.widthAnchor.constraint(equalToConstant: Constants.iconSize),
animation.heightAnchor.constraint(equalToConstant: Constants.iconSize)
])
animation.isAccessibilityElement = true
animation.isAccessibilityElement = false
animation.accessibilityIdentifier = DefaultIdentifiers.Feedback.asset
return animation
}()
Expand Down
11 changes: 1 addition & 10 deletions Sources/MisticaSwiftUI/Components/Feedback/Feedback.swift
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ public struct Feedback<ContentView: View, PrimaryButton: View, SecondaryButton:
private var titleAccessibilityIdentifier: String?
private var messageAccessibilityLabel: String?
private var messageAccessibilityIdentifier: String?
private var imageAccessibilityLabel: String?
private var imageAccessibilityIdentifier: String?

private var feedbackGenerator = UINotificationFeedbackGenerator()
Expand Down Expand Up @@ -70,8 +69,7 @@ public struct Feedback<ContentView: View, PrimaryButton: View, SecondaryButton:
icon
.frame(width: Constants.iconHeight, height: Constants.iconHeight, alignment: .bottomLeading)
.accessibilityIdentifier(imageAccessibilityIdentifier)
.accessibilityLabel(imageAccessibilityLabel)

.misticaBackport.accesibilityHidden(true)
Spacer()
.frame(height: 24)

Expand Down Expand Up @@ -352,12 +350,6 @@ public extension Feedback {
return feedback
}

func imageAccessibilityLabel(_ imageAccessibilityLabel: String?) -> Feedback {
var feedback = self
feedback.imageAccessibilityLabel = imageAccessibilityLabel
return feedback
}

func imageAccessibilityIdentifier(_ imageAccessibilityIdentifier: String?) -> Feedback {
var feedback = self
feedback.imageAccessibilityIdentifier = imageAccessibilityIdentifier
Expand Down Expand Up @@ -455,7 +447,6 @@ private extension View {
.titleAccessibilityIdentifier("Title identifier")
.messageAccessibilityLabel("Message identifier")
.messageAccessibilityIdentifier("Message identifier")
.imageAccessibilityLabel("Image Label")
.imageAccessibilityIdentifier("Image identifier")
}
}
Expand Down

0 comments on commit 5325295

Please sign in to comment.