New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update "Your first theme" documentation #129

Merged

GSadee merged 1 commit into Sylius:2.4 from pocky:patch-doc

Jul 18, 2024

Contributor

pocky commented Aug 22, 2023

Hello!

I am using SyliusThemeBundle on a new Monofony project and after reading documentation (because I always read documentation 👯 ) I seen some problems:

First about theme.json, documentation is always talking about composer.json even if it's possible to have a theme.json and a composer.json (which is explained in docs/theme_configuration_reference.md)
Second on the ThemeRequestListener which is not accurate for Symfony 5+. GetResponseEvent was deprecated in Symfony 4+ for RequestEvent

Thanks for reading and hope it will help!


          doc: Update "Your first theme" documentation

5c3824c

GSadee approved these changes

View reviewed changes

GSadee merged commit 71bc3ab into Sylius:2.4

Member

GSadee commented Jul 18, 2024

Thank you, Alexandre! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet