Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some routing factories into 2 sub-directories #895

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Move some routing factories into 2 sub-directories #895

merged 1 commit into from
Jul 1, 2024
+50 −49

Conversation

loic425
Copy link
Member

@loic425 loic425 commented May 28, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no (it has been added to 1.11 only)
Deprecations? no
Related tickets
License MIT

To improve quality and future maintenance, I split the routing factories into 2 sub-directories.

@loic425 loic425 requested a review from a team as a code owner May 28, 2024 07:21
diimpp
diimpp approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of scope of current PR, it seems some codebase still uses global exception instead of specifalized resource exception.

SyliusResourceBundle/src/Component/src/Symfony/Routing/Factory/RouteName/OperationRouteNameFactory.php

Line 25 in 65abcb6

throw new \RuntimeException(sprintf('No resource was found on the operation "%s"', $operation->getShortName() ?? ''));

@lchrusciel lchrusciel merged commit 9f50383 into Sylius:1.11 Jul 1, 2024
19 checks passed
@lchrusciel
Copy link
Member

Thank you, @loic425!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@diimpp diimpp diimpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loic425 @lchrusciel @diimpp