Implement proper workflow engine shutdown #5367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
pull-request-size
bot
added
size/L
m4dcoder
requested changes
Sep 24, 2021
There was a problem hiding this comment.
If we are implementing proper shutdown, this is not sufficient.
- On shutdown, the workflow engine should remove itself from the service registry.
- If there are other workflow engines in the service registry, then do the shutdown sequence. The shutdown sequence should be something like stop accepting incoming requests and wait until this workflow engine completed processing any requests (not some arbitrary sleep).
- Else if there are no other workflow engine in the service registry, then the workflow engine needs to stop accepting requests, pause all running workflow executions, and then proceed with rest of the shutdown sequence.
- On workflow engine startup, any workflow executions paused by the shutdown should be resumed.
|
@khushboobhatia01 Have we agreed to go for a bigger fix, if so is it ok if i remove this PR from the 3.6 milestone? |
|
Hi @amanda11, I think we can go ahead and remove the milestone tag. I've started working on the approach we've discussed and will close this MR. |
Thanks for update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements graceful workflow engine shutdown. On shutdown, we stop consuming new requests and give existing active requests some time to complete before we kill the engine.