Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid's boolean logic does not support not, so is not functionally complete #526

Closed
Blaisorblade opened this issue Feb 19, 2015 · 2 comments

Comments

@Blaisorblade
Copy link

Liquid should support not — not only because it is the obvious thing to do, but also because it is required to write arbitrary boolean conditions. unless is not sufficient for nested negations --- @nickpearson shows how to compile not by hand in this comment, and the amount of extra needed code is significant.

Moreover, the documentation claims:

Liquid has access to all of the logical and comparison operators.

but because of the absence of not, that's not true.

(I know that there is #138, but it was closed without sufficient discussion).

@fw42
Copy link
Contributor

fw42 commented Feb 19, 2015

I agree that it would be nice to have (same way having support for parentheses would be nice to have). Unfortunately it's not on our roadmap at the moment. But feel free to submit a PR and we will check it out.

@fw42
Copy link
Contributor

fw42 commented Feb 19, 2015

I'm reopening the other one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants