You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After upgrading to version 2.4.1, one of my coworkers (👋 @lukaszstasiakux) noticed an issue with the ui.attached.segment class. It appeared to be overflowing the space it was previously fitting in. In doing some investigating, I believe there may be a math bug with the following two variables:
If you closely at the changes in the above commit for the segment.variables file, you can see that we were previous using addition with a negative number. However, with the changes that were made, we are now using subtraction a negative number. Whoops.
After upgrading to version
2.4.1
, one of my coworkers (👋 @lukaszstasiakux) noticed an issue with theui.attached.segment
class. It appeared to be overflowing the space it was previously fitting in. In doing some investigating, I believe there may be a math bug with the following two variables:/~https://github.com/Semantic-Org/Semantic-UI/blob/2.4.1/src/themes/default/elements/segment.variables#L105-L106
Which was introduced in the following commit:
c249b6c
If you closely at the changes in the above commit for the
segment.variables
file, you can see that we were previous using addition with a negative number. However, with the changes that were made, we are now using subtraction a negative number. Whoops.Steps
.../examples/attached.html
in a browserSegment 1
segmentExpected Result
The
width
andmax-width
properties should be98%
Actual Result
The
width
andmax-width
properties are102%
Version
2.4.1
Testcase
https://jsfiddle.net/notfunk/yax4qewz/2/
The text was updated successfully, but these errors were encountered: