-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jQuery dependency #206
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
318a5bb
to
75fcc83
Compare
3bbf0c7
to
f34adff
Compare
f34adff
to
2eae33e
Compare
bea9628
to
19fed28
Compare
a0db21b
to
3a840bf
Compare
import faker from 'faker' | ||
import React, { Component } from 'react' | ||
import { Button, Dropdown } from 'stardust' | ||
|
||
const getOptions = () => _.times(3, () => { | ||
const getOptions = () => _.times(5, () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 > 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed the dropdown to scroll with options and have more items for search matches. Again, this PR is not actually ready yet.
811e61d
to
9dba194
Compare
This was referenced Apr 27, 2016
Merged
Merged
969a6a5
to
336ee05
Compare
Merged
93116a0
to
03bb949
Compare
This was referenced Apr 30, 2016
Merged
Merged
e86a868
to
5b5c6d4
Compare
5b5c6d4
to
0a22b86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated to #247