[🐛 Bug]:

[neobis001]

What happened?

In this site, in the section "Switching windows or tabs", the bottom of the Python example covers up some of the documentation text. Here's a picture of it.

What browsers and operating systems are you seeing the problem on?

Google Chrome
Version 105.0.5195.127 (Official Build) (64-bit)
Windows 10 Pro

[titusfortner]

Thanks for raising this. We have new code that is supposed to check the contents of the tab and calculate the largest and set the height of all of them to that value. I'll figure out why it isn't detecting the content height properly.

[neobis001]

I looked a little at it myself. I saw your commit. I didn't know Javascript, but I did know Chrome's Inspect tool. I looked at tabpane-persist.js. I checked the "heightMap" dictionary. For the picture I sent, heightMap["tabs-1-content"] was relevant. It looked correct. Also the Math.max.apply line looked correct. I used a breakpoint to edit the Math.max.apply line to add 100 pixels more to the "tabContent" height. Now the website looks fine.

Here's a picture of me using Inspect. Overall, I think your code is fine. Maybe just add more padding for the height?

[titusfortner]

yeah, but the vast majority of tabs don't need padding and I have no idea if 100 is always enough.

I also don't know JS, so I'm a bit at a loss with it. When I put a debug point in the code and loaded the page, and executed maxHeight in the console it gave me the right value, but when I let it execute from the JS file it gave me the wrong value. I have no idea why they would be different. For now I reverted the change.

Maybe a docsy dev will know what is happening — google/docsy#1227 (comment)

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.