Added basic importing function for exported lists! #2105

yigitemres · 2018-03-08T17:37:06Z

Added basic importing function for exported lists! #1863
Feel free to fix any mistakes!
PS: I'm very new to ps1 scripting. Any suggestion can take time! 😄

excitoon · 2018-03-08T23:09:44Z

libexec/scoop-import.ps1

+                {
+                    if($line -ne "") #Checks empty line!
+                    {
+                        $appslist += $line.Split()[0] + " "


What if we have duplicate packages on the list or dependency of some package and the package itself?

Duplicate packages are also going to into list but, because of the nature scoop install they are not installed. But you are right, duplicates are trying to install by this script. I will look into it. Thx for your comments! 🥂

excitoon · 2018-03-08T23:10:33Z

libexec/scoop-import.ps1

+
+
+$filePaths = $args
+importApps(createAppsList($filepaths))


I think we should report %ERRORLEVEL% with result of the operation.

I will add this too. Thx again! 👍

rasa · 2018-03-09T06:32:38Z

Can import ignore lines that start with a # or ; char?

yigitemres · 2018-03-09T07:17:59Z

@rasa Nope currently, but thx to you it will. 🥂
Edit: It's done!

┌[⚡ yigit] [10:46]
└[~\Desktop]> cat .\kdiff3.txt
#kdiff3
kdiff3

#
;

;kdiff3# #123
┌[⚡ yigit] [10:46]
└[~\Desktop]> cat .\unzip.txt
  unzip
 #unzip
unzip
#unzip
;;unzip
#;unzip
;#unzip
 unzip
┌[⚡ yigit] [10:46]
└[~\Desktop]> scoop import .\kdiff3.txt .\unzip.txt
kdiff3
unzip

@rasa

Thx @rasa for advice!

@excitoon

Thx @excitoon for advice!

rasa · 2018-03-09T16:04:59Z

Since scoop export says it Exports (an importable) list of installed apps, scoop import should be able to consume its output, and act accordingly. To that end, we may want to consider that scoop import should:

Install globally, if *global* is found.
Install the 32bit version, if {32bit} is found.
Add the appropriate bucket, if [bucket] is found. For non-standard buckets, this should fail (until we add the bucket location to the export file).
Install “url” apps, if a [url] app is found.
Consider supporting the alternate bucket convention bucket/appname.
Consider supporting pinning of specific versions, using appname@version.
Consider maybe adding flags to quit on the first failure, or ignore all failures and plow on.
Gracefully ignore apps that are already installed.
Consider adding switches to either report/fail, or uninstall/reinstall, if the installed app is not the same as the one listed in the import file (different bucket/url, architecture, or globalness ).

Have I captured everything? @r15ch13?

yigitemres · 2018-03-09T17:28:54Z

@rasa Thx for suggestions. 1 and 2 is done! As I said earlier, I'm pretty new to PS scripting but I try my best. 🥂

@rasa

Thx @rasa for advice!

@rasa

Thx @rasa for advice!

r15ch13 · 2018-03-09T19:29:25Z

@rasa sounds about right.
6. export has to be modified so it will output this info
7. "plowing" through might be difficult because of the bad error handling 😢
8. scoop install does this already

@yigitemres I don't want to be rude, but this https://blog.codinghorror.com/flattening-arrow-code/ might be a good read for you. 😃

yigitemres · 2018-03-09T19:48:27Z

@r15ch13 It could be worse. It could be spaghetti with switch cases and arrow code! 🤣 My first ever C++ homework is resulted with spaghetti code and I had to rewrite it just day before the deadline!

I just write this sake of QoL. It will be possibly deleted or changed (if it is ever merged!) in time. I maybe calling these ifs as function (or found clever way to check string for multiple case with ease) in order to become a little more easy to read.

Any fix or suggestions are welcomed as always!
(BTW, If someone had already create import function, please create pull request. I will be happily delete this. All I want to achieve is that eliminating issues and contributing this wonderful project.)

yigitemres · 2018-03-09T23:29:40Z

@rasa * for wildcards. We are both wrong. 😆 It should be *{32bit}*. (When apps name like "dasapp32bit", it was passed as --arch 32bit)

Thx for warning. 🥂

yigitemres · 2018-03-12T19:54:38Z

libexec/scoop-import.ps1

+                try {
+                    scoop install $Matches.url $globalArgs.TrimEnd(" ") $archArgs.TrimEnd(" ")
+                }
+                catch {


I cannot figure out how to catch if $Matches.url not exist or not reachable? If anybody have suggestions, I'm very happy to hear it!

You could check status code of the url HEAD

PS > Invoke-WebRequest -Uri 'community.spiceworks.com' -Method 'HEAD' | select StatusCode StatusCode ---------- 200

nitrocode · 2018-10-14T18:00:03Z

Will there be a Scoopfile similar to Brewfile where it will contain both command line installs and installs from its extras and other buckets?

I'm in favor of the # prefix instead of the old ; way. # seems to be more consistent with powershell and other languages where as the ; reminds me of ini files.

~~also if that's true, will the exported file also auto-add whatever buckets are required?~~ nvm just saw #3 on the list in @rasa's post.

Thanks for all the hard work on this.

nitrocode · 2018-10-14T18:06:20Z

libexec/scoop-import.ps1

+    else {
+        return $false
+    }
+}


I believe above can be reduced to this.

function checkFileExt ($file) { return ([IO.Path]::GetExtension($file) -eq ".txt") }

The above simplification can be applied to functions below and would make the code more concise and thus make it more readable.

scadu · 2019-02-02T21:10:51Z

What's the status of this merge request? I see that @yigitemres removed his repository.

I started playing with scoop export trying to install package from array when item not installed.
The only property available from scoop export seems to be Length which is not very useful, but most probably I'm missing something.

import would be really useful for provisioning. I might take a look if no one is interested in introducing this feature. Please note that I haven't touched PowerShell before except my deploy script.

yigitemres · 2019-02-03T04:09:11Z

What's the status of this merge request? I see that @yigitemres removed his repository.

"I will be Bach" Arnold, probably...

I will fork again and work on it. If anyone comes with cleaner version (which you should 😃) I will be happy. My main aim to try to implement this feature because of two reasons. First one is QoL change and the second one is that learning PS.

Thanks for all ideas, suggestions and warnings. I hope that we will see this feature in the near future. 🥂

yigitemres · 2020-04-13T08:09:32Z

NecroBump?!

Hi guys, It's been a long time. I remember that we have unfinished business with this unimplemented feature. I will be very happy if you can help me. I'm gonna try to add all(?) previously mentioned features (I have some objections about some of them) with clean code. If you have suggestions, please comment. 🥂 For a testing purposes I need something. Can somebody export of their scoop list and paste it here if;

The person installed app from json file.
The person installed app from manifest url.

I'm using WSLGentoo as a scoop replacement. Because of this, I need these exports for testing purposes. Installing scoop apps with many different conditions is a real burden for me for now. 😢

I hope that this will finished really soon with your helps.

Have a nice day! 🤗

yigitemres · 2020-08-23T02:29:44Z

Final NecroBump!

@scadu If you accept I have a mission for you. (Mission Impossible intensifies 😁)

I think that no one interest with import function and I'm fully migrated from this package manager to another. If anyone have better solution please pr.

Have a nice day! 🥂

yigitemres added 4 commits March 8, 2018 20:35

Added basic importing function for exported lists!

dbffcd4

Whitespace fix!

cc5fe99

Adding TrimEnd for eliminating last " ".

2c05ca4

Added txt file check!

b48ea8f

excitoon reviewed Mar 8, 2018

View reviewed changes

yigitemres added 2 commits March 9, 2018 10:50

Added ignoring commenting lines!

677d86d

Thx @rasa for advice!

Added elemination of duplicate packages!

8933f23

Thx @excitoon for advice!

yigitemres added 2 commits March 9, 2018 20:40

Added global and arch keywords!

bb5d0ef

Thx @rasa for advice!

Added url(json) support!

9fc74b7

Thx @rasa for advice!

Added checking installed apps!

cda4ba3

rasa mentioned this pull request Mar 12, 2018

query: scoop export #1863

Closed

Cleaning code as much as I can!

36d3898

yigitemres commented Mar 12, 2018

View reviewed changes

ScoopInstaller deleted a comment Oct 1, 2018

nitrocode reviewed Oct 14, 2018

View reviewed changes

Calinou mentioned this pull request Nov 13, 2019

[Suggestion] Replicating the install configuration on multiple machines #3744

Closed

yigitemres mentioned this pull request Jun 26, 2020

Updating Python cause PIP Packages Removed! #2180

Closed

yigitemres closed this Aug 23, 2020

rashil2000 mentioned this pull request Jan 1, 2022

[Feature request] Import command #3934

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added basic importing function for exported lists! #2105

Added basic importing function for exported lists! #2105

yigitemres commented Mar 8, 2018 •

edited

Loading

excitoon Mar 8, 2018

yigitemres Mar 9, 2018

excitoon Mar 8, 2018

yigitemres Mar 9, 2018

rasa commented Mar 9, 2018

yigitemres commented Mar 9, 2018 •

edited

Loading

rasa commented Mar 9, 2018

yigitemres commented Mar 9, 2018

r15ch13 commented Mar 9, 2018

yigitemres commented Mar 9, 2018 •

edited

Loading

yigitemres commented Mar 9, 2018

yigitemres Mar 12, 2018 •

edited

Loading

nitrocode Feb 2, 2019

nitrocode commented Oct 14, 2018 •

edited

Loading

nitrocode Oct 14, 2018

scadu commented Feb 2, 2019

yigitemres commented Feb 3, 2019 •

edited

Loading

yigitemres commented Apr 13, 2020 •

edited

Loading

yigitemres commented Aug 23, 2020



		$filePaths = $args
		importApps(createAppsList($filepaths))

Added basic importing function for exported lists! #2105

Added basic importing function for exported lists! #2105

Conversation

yigitemres commented Mar 8, 2018 • edited Loading

excitoon Mar 8, 2018

Choose a reason for hiding this comment

yigitemres Mar 9, 2018

Choose a reason for hiding this comment

excitoon Mar 8, 2018

Choose a reason for hiding this comment

yigitemres Mar 9, 2018

Choose a reason for hiding this comment

rasa commented Mar 9, 2018

yigitemres commented Mar 9, 2018 • edited Loading

rasa commented Mar 9, 2018

yigitemres commented Mar 9, 2018

r15ch13 commented Mar 9, 2018

yigitemres commented Mar 9, 2018 • edited Loading

yigitemres commented Mar 9, 2018

yigitemres Mar 12, 2018 • edited Loading

Choose a reason for hiding this comment

nitrocode Feb 2, 2019

Choose a reason for hiding this comment

nitrocode commented Oct 14, 2018 • edited Loading

nitrocode Oct 14, 2018

Choose a reason for hiding this comment

scadu commented Feb 2, 2019

yigitemres commented Feb 3, 2019 • edited Loading

yigitemres commented Apr 13, 2020 • edited Loading

yigitemres commented Aug 23, 2020

yigitemres commented Mar 8, 2018 •

edited

Loading

yigitemres commented Mar 9, 2018 •

edited

Loading

yigitemres commented Mar 9, 2018 •

edited

Loading

yigitemres Mar 12, 2018 •

edited

Loading

nitrocode commented Oct 14, 2018 •

edited

Loading

yigitemres commented Feb 3, 2019 •

edited

Loading

yigitemres commented Apr 13, 2020 •

edited

Loading